Make vcpkg optional and enabled by default - #19
Open
Aleksei Nikiforov (AlekseiNikiforovIBM) wants to merge 2 commits into
Open
Make vcpkg optional and enabled by default#19Aleksei Nikiforov (AlekseiNikiforovIBM) wants to merge 2 commits into
Aleksei Nikiforov (AlekseiNikiforovIBM) wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a configurable toggle to enable/disable vcpkg-related build flags when running the build script in Docker.
Changes:
- Introduces a new GitHub Action input
use_vcpkg. - Reads
use_vcpkgin the Node action script. - Conditionally appends
--use_vcpkgand--use_vcpkg_ms_internal_asset_cachebased on the input.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/run-build-script-in-docker/index.js | Reads the new input and conditionally adds vcpkg flags to the build args. |
| actions/run-build-script-in-docker/action.yml | Defines the new use_vcpkg input and its default. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
Any feedback? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make vcpkg optional and enabled by default.
Option for build without vcpkg is needed for platforms where vcpkg is not available at the moment, like s390x.
Additional testing is needed to ensure that everything works as intended, only basic testing was done.